Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A functionality is added so that through the command line the path where the generated icons will be saved can be specified.
Problem or Related Task
While working on my project, which required the icons to be executed in a specific path, the opportunity arose for the icon save path to be managed from the command line.
Changes Made
The scope of the variable
iconsPathis changed tolet, as it is intended to be updated in case a new path comes from the command line.Within the generateIcons function, a validation is added to determine if there is a string in the
argIconNamesarray that starts with--path=. If this condition istrue, the index where the match of the string starting with--path=is found is obtained. Then, the value of the path is obtained by substring starting from the length of--path=. Finally, the path is obtained, and the value of iconsPath is reassigned.If it cannot be identified that a string starting with
--path=exists in the array, the value oficonsPathremains with the default value.Tests Performed
(Describe the tests you have conducted to ensure your changes work as expected)
Testing Steps
(Provide step-by-step instructions for the reviewer to test your changes)
Additional Notes
(Any other relevant information you want to add)