Looking to add more columns #1
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now I haven't changed anything, just added a comment which indicates my intention. As a matter of fact, the primary purpose of this PR is to indicate intention.
I want more columns returned. I'm working with the West Coast Bottom Trawl Survey, so I'll start there. How to handle flexible column returns while still providing reasonable defaults is not something I think I've perfected. But it is something that I've attempted w/ success in personal packages.
For an example of how I deal with flexible column returns, see: https://github.com/rBatt/trawlData/blob/master/R/clean.trimCol.R Looking at that, I'm noticing that I didn't complete my own example (sorry!). However, the c.add and c.drop column are what to focus on. Basically, there's a default set of columns to return. You can add any candidate column via
c.add, and remove any default viac.drop. To make the recommendation truly useful, you just have to make sure to not include too many or too few columns, which I think you have in your current function.To start, I will just add more columns to be returned. Then I might try to add a
c.addargument to the parent function that is ignored for all cases except WCBTS.The extra columns I add depends on what is used by a project @mpinsky leads; particularly a large all-purpose script, which fuels OceanAdapt, requires variables like "depth".
Actual changes and commits will start showing up later today. I'm working on this project this week.
Thanks for making this package, very helpful!