Skip to content
This repository was archived by the owner on Sep 11, 2023. It is now read-only.

Adds option for blank slots to appear before bag slots#50

Closed
Ketrel wants to merge 6 commits intoJaliborc:masterfrom
Ketrel:blankmod-202004
Closed

Adds option for blank slots to appear before bag slots#50
Ketrel wants to merge 6 commits intoJaliborc:masterfrom
Ketrel:blankmod-202004

Conversation

@Ketrel
Copy link
Copy Markdown

@Ketrel Ketrel commented Apr 27, 2020

This superseded my earlier pull request for the same effect ( #32 )

Without the option enabled (default): https://i.imgur.com/ek7P2dD.png
With the option enabled: https://i.imgur.com/KYwnS4c.png

@Ketrel
Copy link
Copy Markdown
Author

Ketrel commented Apr 27, 2020

This is currently having issues

  1. With the bank
  2. When bags are hidden (this one I've solved for the main bags, but not the bank)

@Ketrel
Copy link
Copy Markdown
Author

Ketrel commented Apr 28, 2020

The additional commit 9d11bcd should address both the bank, and hidden cases.

@Ketrel
Copy link
Copy Markdown
Author

Ketrel commented May 4, 2020

Commit 470e8f0 means this option works when viewing the bank in offline mode as well.

@Ketrel Ketrel force-pushed the blankmod-202004 branch from 470e8f0 to 0ff7aa9 Compare July 17, 2020 21:07
@Ketrel
Copy link
Copy Markdown
Author

Ketrel commented Jul 17, 2020

That was rebasing it on your latest.

@Ketrel
Copy link
Copy Markdown
Author

Ketrel commented Oct 15, 2020

In my repo, I rebased a new branch on the current wildpants master. Would you want me to close this and open a pull request for that branch?

@Ketrel
Copy link
Copy Markdown
Author

Ketrel commented Oct 15, 2020

Superseded by #59

@Ketrel Ketrel closed this Oct 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant