Closed
Conversation
Summary This PR improves the NeoForge mod loader implementation with better reliability and extended version support. Changes Multiple Download Sources Added support for multiple NeoForge repositories as fallback options Automatic retry with different URLs if download fails Includes both installer JAR and regular JAR files Fallback Mechanisms Implemented hardcoded version mapping for when API is unavailable Added offline profile creation when installer fails Improved error handling and retry logic Extended Version Support Added support for Minecraft versions up to 1.21.10 Complete version mapping for recent Minecraft releases Better version detection from NeoForge version strings Installation Process Primary method: Traditional Java installer execution Fallback method: Manual profile creation with direct JAR download Detailed status updates during installation Benefits Higher success rate for NeoForge installation Works in environments with limited repository access Better user experience with progress feedback Support for latest Minecraft versions Compatibility Maintains full backward compatibility Uses existing mod loader API No breaking changes to public interface
|
This Repo is just a mirror of the Codeberg Repo. PRs arren't acceptet here. Please make a PR against the Codeberg Repo. It works the same Way as in GitHub. You can use your GitHub Account to login into Codeberg. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves the NeoForge mod loader implementation with better reliability and extended version support.
Changes
Multiple Download Sources
Added support for multiple NeoForge repositories as fallback options Automatic retry with different URLs if download fails Includes both installer JAR and regular JAR files
Fallback Mechanisms
Implemented hardcoded version mapping for when API is unavailable Added offline profile creation when installer fails Improved error handling and retry logic
Extended Version Support
Added support for Minecraft versions up to 1.21.10 Complete version mapping for recent Minecraft releases Better version detection from NeoForge version strings
Installation Process
Primary method: Traditional Java installer execution Fallback method: Manual profile creation with direct JAR download Detailed status updates during installation
Benefits
Higher success rate for NeoForge installation
Works in environments with limited repository access Better user experience with progress feedback
Support for latest Minecraft versions
Compatibility
Maintains full backward compatibility
Uses existing mod loader API
No breaking changes to public interface