feat: custom props to Table and show sort arrow on hover #1226
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Integrated TanStack Table's internal pagination model (getPaginationRowModel) for more robust state management. Created a standalone, reusable DataTablePagination component located within the DataTable module. Refactored the Structured View implementation: Merged TableStructuredCell logic into TableCell for a cleaner architecture. Moved the expand/collapse click handler to the root cell element to improve hit area. Added W3C ARIA accessibility attributes (aria-expanded, aria-level, role="row"). Enhanced component robustness by adding safe initializers for pageSize and handling empty data edge cases (e.g., "0-0" range display). Updated Storybook stories with comprehensive examples, including combined support for pagination, sorting, and structured views. Resolved linting issues and standardized flex layouts for better cross-browser consistency.
- Forward className and spread props from DataTable to Table component - Add rowProps and cellProps for custom attributes (e.g., data-testid for Cypress) - Hide sort arrow by default on sortable columns, reveal on hover - Keep sort arrow always visible when column is actively sorted
BouklifYacine
changed the title
This was
linked to
issues
Jan 2, 2026
ffffffelix
requested changes
Jan 5, 2026
Comment on lines
25
to
26
| {'moonstone-tableCellHead_sortActive': isActive}, | ||
| {'moonstone-tableCellHead_sortHidden': !isActive} |
Collaborator
There was a problem hiding this comment.
Instead of switching two classes, can we set it hidden by default and display it with moonstone-tableCellHead_sortActive
| return ( | ||
| <div className="moonstone-dataTable"> | ||
| <Table> | ||
| <Table className={className} {...tableProps}> |
Collaborator
There was a problem hiding this comment.
As we don't use moonstone-dataTable can we get rid of the wrapper div
| rowsPerPageOptions, | ||
| paginationLabel | ||
| paginationLabel, | ||
| ...tableProps |
Collaborator
There was a problem hiding this comment.
As other components we can name it ...props instead of ...tableProps
| * Function to add custom HTML attributes to the cell element | ||
| * @param row - The row data | ||
| */ | ||
| cellProps?: (row: T) => React.HTMLAttributes<HTMLTableCellElement> & Record<string, unknown>; |
Collaborator
There was a problem hiding this comment.
I think it should be an object instead of a function so it doesn't depend on row; this way, our users can add any custom attributes to the cell.
| * Function to add custom HTML attributes to each row element | ||
| * @param row - The row data | ||
| */ | ||
| rowProps?: (row: T) => React.HTMLAttributes<HTMLTableRowElement> & Record<string, unknown>; |
Collaborator
There was a problem hiding this comment.
I think it should be an object instead of a function so it doesn't depend on row; this way, our users can add any custom attributes to the row.
- Remove wrapper div around DataTable (moonstone-dataTable unused) - Simplify sort icon CSS: hidden by default, visible on hover or when active - Rename ...tableProps to ...props for consistency with other components - Change rowProps from function to object for static attribute support - Change cellProps from function to object for static attribute support
ffffffelix
approved these changes
Jan 5, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.