feat: add the Tablepagination and structured data #1225
+189
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Integrated TanStack Table's internal pagination model (getPaginationRowModel) for more robust state management. Created a standalone, reusable DataTablePagination component located within the DataTable module. Refactored the Structured View implementation: Merged TableStructuredCell logic into TableCell for a cleaner architecture. Moved the expand/collapse click handler to the root cell element to improve hit area. Added W3C ARIA accessibility attributes (aria-expanded, aria-level, role="row"). Enhanced component robustness by adding safe initializers for pageSize and handling empty data edge cases (e.g., "0-0" range display). Updated Storybook stories with comprehensive examples, including combined support for pagination, sorting, and structured views. Resolved linting issues and standardized flex layouts for better cross-browser consistency.
This was
linked to
issues
Jan 2, 2026
ffffffelix
requested changes
Jan 5, 2026
| export const DataTablePagination: React.FC<DataTablePaginationProps> = ({ | ||
| className, | ||
| label = { | ||
| rowsPerPage: 'Rows per page', |
Collaborator
There was a problem hiding this comment.
I suggest displaying items instead of Rows per page to prevent to use row
- Move DataTablePagination to src/components/Pagination as standalone component - Rename row-based props to item-based (rowsPerPage → itemsPerPage, etc.) - Replace margin utility classes with CSS gap for layout - Remove deprecated Dropdown label prop - Change data-sel-role attributes to data-testid - Use type imports for TypeScript types - Update DataTable to consume new Pagination component - Export Pagination from main components index
ffffffelix
requested changes
Jan 5, 2026
| } | ||
|
|
||
| .moonstone-pagination_navigation { | ||
| display: flex; |
Collaborator
There was a problem hiding this comment.
You can use helper classes flexRow, alignCenter to avoid to add them for each elements
Collaborator
There was a problem hiding this comment.
Since you added the helper classes, you can now clean up this CSS to remove unnecessary styles :)
ffffffelix
requested changes
Jan 5, 2026
| } | ||
|
|
||
| .moonstone-pagination_navigation { | ||
| display: flex; |
Collaborator
There was a problem hiding this comment.
Since you added the helper classes, you can now clean up this CSS to remove unnecessary styles :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.