feat: added align method for cell and the primary key prop #1224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Jan 2, 2026
ffffffelix
requested changes
Jan 5, 2026
| isSortable: true, | ||
| sortFn: (a: T, b: T) => get(a) - get(b), | ||
| align: options?.align ?? 'right' | ||
| align: options?.align ?? 'left' |
Collaborator
There was a problem hiding this comment.
Number columns should be aligned to the right by default.
ffffffelix
reviewed
Jan 5, 2026
| /** | ||
| * Whether this row can be expanded (has children) | ||
| */ | ||
| isExpandable: boolean; |
Collaborator
There was a problem hiding this comment.
Maybe we should make isExpandable optional and set it to false by default.
What do you think?
ffffffelix
approved these changes
Jan 5, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.