chore: update AccordionItem to meet W3C standards #1075
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
These modifications could have a big impact and cause a lot of breaking changes. This PR will be closed for now. |
ffffffelix
added
patch
ffffffelix
requested changes
Jul 21, 2025
Collaborator
ffffffelix
left a comment
ffffffelix
left a comment
There was a problem hiding this comment.
-
As all interactions should be at the button level, we also have to update our styling to reflect that. All states style (
:hover,:active,:focus-visible) should be on the button. Maybe we can refactor our CSS. -
I propose to simplify
data-testidlabel withaccordion-instead ofaccordion-item-as theAccordioncomponent is only a wrapper.
| aria-expanded={open} | ||
| {...onAccessibleClick({onClick: e => handleClick(e, open)})} | ||
| role="accordion-item" | ||
| data-testid="accordion-item" |
Collaborator
There was a problem hiding this comment.
- Maybe we don't need to add a
data-testidat this level, as there is no interaction or direct things to target - As ' aria-expanded` is at the button level, we should remove it from the heading.
- Same for
aria-controlsthat should be on the button. (W3C doc)
Contributor
Author
|
This PR will remain in draft until the next release, as the impact of the changes needs to be discussed with other teams. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AccordionItem
headerwithh3elementrole="accordion-item"buttonelement aroundh3's contentdata-testid="accordion-button"tobuttonelementaria-expandedattribute tobuttonelementaria-controlsattribute tobuttonelementdata-testid="accordion-label"toTypographyelement