fix: Correct Export-Package of GraalVM classes #610
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baptistegrimaud
force-pushed
the
missing-export-packages-graalvm
branch
from
6de8365 to
3de172e
Compare
baptistegrimaud
force-pushed
the
missing-export-packages-graalvm
branch
from
3de172e to
d5c73ab
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR corrects the Export-Package configuration for GraalVM classes in the javascript-modules-engine to restore backward compatibility. Previously, the export packages used wildcards (org.graalvm.*, com.oracle.truffle.*, com.oracle.js.*) which were replaced with an incomplete explicit list. This change restores the full list of 139 specific packages that were originally exported by Jahia.
Key changes:
- Replaced wildcard exports with explicit package declarations for GraalVM, Oracle Truffle, and Oracle JS packages
- Restored all previously exported packages to maintain backward compatibility
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
dgriffon
approved these changes
Dec 18, 2025
dgriffon
approved these changes
Dec 18, 2025
Contributor
With:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The packages that used to be exported by Jahia (see https://github.com/Jahia/jahia-private/pull/4566/changes#diff-11ea8453e7a920e0559a8fa75a0bdf5909512e1b97939812e42a369f2931aa34) were not exported by the JavaScript Modules engine (changes in #601) as the property name was incorrect.
The plan is to review the list of GraalVM exported classes for the next major release of Jahia (8.3.0.0): https://github.com/Jahia/jahia-private/issues/4576.
Tip
Documentation to guide the reviews: How to do a code review