ci: Use correct branch on merge to main #564
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a workflow configuration issue where the integration tests workflow was using the wrong branch (master instead of main) when triggered on merge to main. The fix ensures the workflow uses the correct branch reference from the triggering event.
Key Changes:
- Added
module_branchparameter to the integration tests workflow to use the current GitHub ref instead of defaulting tomaster
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
GauBen
approved these changes
Nov 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
reusable-integration-tests.ymlusesmasteras default branch.So set it to
${{ github.ref }}to use the correct branch (mainin the current setup).Should fix the On merge to main workflow currently broken: https://github.com/Jahia/javascript-modules/actions/runs/19422103524
Tip
Documentation to guide the reviews: How to do a code review