-
Notifications
You must be signed in to change notification settings - Fork 1
refactor: rebrand hydration components as <Island> #447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR refactors the hydration system by introducing a new Island component that replaces the existing HydrateInBrowser and RenderInBrowser components. The refactoring consolidates hydration functionality into a single, more flexible component following the Island Architecture paradigm.
- Introduces the new
Islandcomponent with comprehensive TypeScript typing and flexible hydration modes - Deprecates
HydrateInBrowserandRenderInBrowsercomponents while maintaining backward compatibility - Updates client-side hydration logic to use a unified DOM marker (
jsm-island) and simplified client-only detection
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| javascript-modules-library/src/components/render/Island.tsx | New comprehensive Island component implementation with complex TypeScript generics |
| javascript-modules-library/src/components/render/RenderInBrowser.tsx | Deprecated component now delegates to Island with clientOnly flag |
| javascript-modules-library/src/components/render/HydrateInBrowser.tsx | Deprecated component now delegates to Island without clientOnly flag |
| javascript-modules-library/src/components/render/internal/InBrowser.tsx | Removed internal implementation replaced by Island |
| javascript-modules-engine/src/client-javascript/react/index.tsx | Updated client hydration logic to use new DOM markers and detection |
| javascript-modules-library/tsconfig.json | Added verbatimModuleSyntax TypeScript option |
| Multiple test and example files | Updated to use new Island component API |
javascript-modules-engine/src/client-javascript/react/index.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Baptiste Grimaud <bgrimaud@jahia.com>
Co-authored-by: Baptiste Grimaud <bgrimaud@jahia.com>
Description
Closes #251
Checklist
Source code
Tests
Tip
Documentation to guide the reviews: How to do a code review