fix(ci): auto-approve release-please PRs to unblock auto-merge#99
Merged
JacobPEvans merged 2 commits intomainfrom Mar 15, 2026
Merged
fix(ci): auto-approve release-please
PRs to unblock auto-merge#99JacobPEvans merged 2 commits intomainfrom
JacobPEvans merged 2 commits intomainfrom
Conversation
Release-please PRs created by the GitHub App have auto-merge enabled but never merge because the pull_request ruleset leaves reviewDecision empty. Add a gh pr review --approve step using GITHUB_TOKEN (github-actions[bot]) which is a different identity from the PR author (the GitHub App), satisfying GitHub's self-approval restriction. (claude)
|
Note Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported. |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the reusable release-please workflow to ensure release-please PRs can satisfy required-approval branch protections and proceed with auto-merge.
Changes:
- Adds
pull-requests: writepermission to the workflow job (and updates the caller example). - Adds a new step that approves the release-please PR using
GITHUB_TOKENviagh pr review --approve.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
- Add header comment documenting the org/repo setting required for GITHUB_TOKEN approval and the pull-requests: write caller requirement - Extract PR number resolution to a dedicated `find-pr` step with a step output, eliminating the duplicated gh pr list call across auto-merge and approval steps (claude)
JacobPEvans
added a commit
to JacobPEvans/ansible-proxmox
that referenced
this pull request
Mar 15, 2026
The reusable _release-please.yml workflow now approves release PRs using GITHUB_TOKEN, which requires pull-requests: write from the caller. Related to JacobPEvans/.github#99 (claude)
JacobPEvans
added a commit
to JacobPEvans/ansible-splunk
that referenced
this pull request
Mar 15, 2026
The reusable _release-please.yml workflow now approves release PRs using GITHUB_TOKEN, which requires pull-requests: write from the caller. Related to JacobPEvans/.github#99 (claude)
JacobPEvans
added a commit
to JacobPEvans/nix-ai
that referenced
this pull request
Mar 15, 2026
The reusable _release-please.yml workflow now approves release PRs using GITHUB_TOKEN, which requires pull-requests: write from the caller. Related to JacobPEvans/.github#99 (claude)
JacobPEvans
added a commit
to JacobPEvans/nix-darwin
that referenced
this pull request
Mar 15, 2026
The reusable _release-please.yml workflow now approves release PRs using GITHUB_TOKEN, which requires pull-requests: write from the caller. Related to JacobPEvans/.github#99 (claude)
JacobPEvans
added a commit
to JacobPEvans/ansible-proxmox-apps
that referenced
this pull request
Mar 15, 2026
The reusable _release-please.yml workflow now approves release PRs using GITHUB_TOKEN, which requires pull-requests: write from the caller. Related to JacobPEvans/.github#99 (claude)
JacobPEvans
added a commit
to JacobPEvans/nix-darwin
that referenced
this pull request
Mar 15, 2026
) The reusable _release-please.yml workflow now approves release PRs using GITHUB_TOKEN, which requires pull-requests: write from the caller. Related to JacobPEvans/.github#99 (claude)
JacobPEvans
added a commit
to JacobPEvans/terraform-proxmox
that referenced
this pull request
Mar 15, 2026
The reusable _release-please.yml workflow now approves release PRs using GITHUB_TOKEN, which requires pull-requests: write from the caller. Related to JacobPEvans/.github#99 (claude)
This was referenced Mar 15, 2026
Merged
Merged
fix(ci): add pull-requests: write for release-please auto-approval
JacobPEvans/terraform-proxmox#191
Merged
Merged
JacobPEvans
added a commit
to JacobPEvans/ansible-proxmox
that referenced
this pull request
Mar 15, 2026
The reusable _release-please.yml workflow now approves release PRs using GITHUB_TOKEN, which requires pull-requests: write from the caller. Related to JacobPEvans/.github#99 (claude)
JacobPEvans
added a commit
to JacobPEvans/nix-darwin
that referenced
this pull request
Mar 15, 2026
) The reusable _release-please.yml workflow now approves release PRs using GITHUB_TOKEN, which requires pull-requests: write from the caller. Related to JacobPEvans/.github#99 (claude)
JacobPEvans
added a commit
to JacobPEvans/ansible-proxmox-apps
that referenced
this pull request
Mar 15, 2026
) The reusable _release-please.yml workflow now approves release PRs using GITHUB_TOKEN, which requires pull-requests: write from the caller. Related to JacobPEvans/.github#99 (claude)
JacobPEvans
added a commit
to JacobPEvans/ansible-splunk
that referenced
this pull request
Mar 15, 2026
* fix(ci): add pull-requests: write for release-please auto-approval The reusable _release-please.yml workflow now approves release PRs using GITHUB_TOKEN, which requires pull-requests: write from the caller. Related to JacobPEvans/.github#99 (claude) * ci: trigger CodeQL scan (claude)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #99 Update
Summary
Release-please PRs created by the GitHub App have auto-merge enabled but never merge because
the pull_request ruleset leaves
reviewDecisionempty. This fix adds agh pr review --approvestep using
GITHUB_TOKEN(github-actions[bot]) which is a different identity from the PR author(the GitHub App), satisfying GitHub's self-approval restriction and unblocking auto-merge.
Additionally, the fix documents the org/repo setting required for GITHUB_TOKEN approval and
deduplicates the PR number lookup across auto-merge and approval steps.
Changes
.github/workflows/_release-please.yml— Add header comment documenting prerequisites,extract PR number resolution to dedicated
find-prstep with output, add approval stepusing GITHUB_TOKEN
Test Plan