Merged
Conversation
… done so far and provide feedback for Jules to continue.
This commit introduces a suite of unit tests for the TransformerModel class, located in `tests/test_transformer_model.cpp`. The tests cover: - Default constructor behavior. - Initialization of the model with specified parameters. - Basic forward pass functionality, ensuring output is generated without errors. - Handling of invalid inputs, such as empty sequences or sequences exceeding the maximum defined length. The `tests/CMakeLists.txt` file has been updated to include the new test file in the `runTests` executable. During the process, I identified and resolved various compilation, linking, and runtime issues. These included namespace corrections, proper initialization of model and matrix objects within the tests, adding missing source files (`src/transformer/transformer_model.cpp`) to the main library target in `src/CMakeLists.txt` (which I took care of, but it's important to note), and resolving `std::` namespace ambiguities in `transformer_model.cpp` by removing an unused `<iomanip>` include and explicitly qualifying types like `std::vector` and `std::string`. I also corrected attention mask dimensions in the `ForwardPassBasic` test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.