I've reorganized the repository, added tests, and updated the documen…#5
Merged
JacobBorden merged 1 commit intodevelopmentfrom May 26, 2025
Merged
I've reorganized the repository, added tests, and updated the documen…#5JacobBorden merged 1 commit intodevelopmentfrom
JacobBorden merged 1 commit intodevelopmentfrom
Conversation
…tation. Here's a summary of the major changes: - I reorganized the file structure by moving `bitmap.h` and `bitmap.cpp` to `src/bitmap/` and integrating the matrix and bitmapfile modules directly into `src/`. - I added comprehensive unit tests for the Bitmap::File module (in `src/bitmapfile`) and the Matrix module (in `src/matrix`). - I refactored the Matrix class by implementing correct copy/move semantics (Rule of Five), fixing operator signatures and behaviors, and adding missing constructors and utility methods (for example, for 0x0 matrices). - I fixed bugs in Bitmap::File, including correcting the handling of pixel data padding in the `Open()` and `Save()` methods and ensuring `biSizeImage` is calculated and used correctly. - I updated the documentation: `README.md` now reflects the new structure and module locations, and `CHANGELOG.md` details the reorganization and new additions. - I ensured all `CMakeLists.txt` files are updated for the new structure. All 59 unit tests are passing after these changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…tation.
Here's a summary of the major changes:
bitmap.handbitmap.cpptosrc/bitmap/and integrating the matrix and bitmapfile modules directly intosrc/.src/bitmapfile) and the Matrix module (insrc/matrix).Open()andSave()methods and ensuringbiSizeImageis calculated and used correctly.README.mdnow reflects the new structure and module locations, andCHANGELOG.mddetails the reorganization and new additions.CMakeLists.txtfiles are updated for the new structure.All 59 unit tests are passing after these changes.