fix(core): refactor source layout to resolve ModuleNotFoundError #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moves loose python files from `src/` to `src/git_pulsar/` to correct the source layout. Updates internal imports in `system.py` to use relative paths.
Updates test suite to import from `git_pulsar` instead of `src`, ensuring tests target the installed package context correctly.
Updates `pyproject.toml` scripts to point to `git_pulsar.cli` and `git_pulsar.daemon`, fixing the `ModuleNotFoundError` on install.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🐛 Bug Fix
What's changing?
This PR refactors the project structure to adhere to the standard
src-layout.src/tosrc/git_pulsar/.system.pyto use relative paths.pyproject.tomlentry points to point to the new package location (git_pulsar.cli:main).git_pulsar) rather than the source root.Why?
Previously,
srcwas being treated as a package, but in a standard python installation,srcis stripped, leaving only the contents installed. This caused the installed executable to fail with:ModuleNotFoundError: No module named 'src'This change ensures the package is installed correctly as
git_pulsarand can be imported by the generated script entry points.Checks
git-pulsarexecutable runs after install (pip install .)pytestsuite passes with new import structure