refactor(core): centralize constants and resolve log path discrepancy #15
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This refactor decouples logic from configuration by converting
constants.pyinto a pure data module and centralizing all magic strings (file paths, app labels, ignore patterns).It also resolves a critical "split-brain" logging issue where the CLI and Daemon were reading/writing to different log files.
Changes
Core Refactor (
constants.py):_get_state_dirfunction; path resolution is now handled via top-level constants.APP_LABEL,DEFAULT_IGNORES, andGIT_LOCK_FILES.Pathtype hints to satisfy strict static analysis.Bug Fix (
cli.py):tail_logto the centralizedLOG_FILEconstant (XDG State) instead of the hardcoded legacy path (~/.git_pulsar_log)..gitignoredefaults with the centralized list.Daemon & Service:
daemon.pyandservice.pyto importAPP_LABELand paths fromconstantsrather than defining them locally.system.pyto preventReturning Anyerrors in strict mode.Verification
git-pulsar log. It should now correctly tail the active daemon log located in~/.local/state/git-pulsar/daemon.log(or equivalent XDG path).constants.pycontains nodefstatements.