Potions + Powers: Sacred Bark fix + completion#6
Conversation
- Fixed relic name from "SacredBark" to "Sacred Bark" in execute_potion_effect - Removed hardcoded sys.path.insert from conftest.py and test files that pointed to main repo instead of worktree - Fixed class name syntax errors caused by replace_all - All 4193 tests passing Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
This PR is being reviewed by Cursor Bugbot
Details
You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
| return {"success": False, "error": f"Unknown potion: {potion_id}"} | ||
|
|
||
| has_sacred_bark = state.has_relic("SacredBark") | ||
| has_sacred_bark = state.has_relic("Sacred Bark") |
There was a problem hiding this comment.
Sacred Bark relic ID mismatch breaks functionality
High Severity
The code checks for "Sacred Bark" (with space) but the relic definition in relics.py has id="SacredBark" (no space). When relics are obtained in gameplay, they're stored using the canonical ID from the definition. This mismatch causes has_relic("Sacred Bark") to always return False in production, completely breaking the Sacred Bark doubling effect. Tests pass only because they manually set relics=["Sacred Bark"] instead of using the relic system.
1 participant
Summary
Test Results
4193 tests passing
Files Changed
🤖 Generated with Claude Code
Note
Low Risk
Low risk: changes are a string-ID fix for Sacred Bark detection and test harness cleanups, with no new gameplay logic beyond ensuring the existing doubling behavior is actually applied.
Overview
Fixes a relic ID mismatch so potion potency doubling correctly detects Sacred Bark by using
"Sacred Bark"instead of"SacredBark"inexecute_potion_effect.Updates potion-related tests to use the corrected relic ID, and removes hardcoded
sys.pathinjection from the pytest setup (tests/conftest.pyandtests/test_potion_sacred_bark.py).Written by Cursor Bugbot for commit 073d4a5. This will update automatically on new commits. Configure here.