Skip to content

Conversation

@JackRobards
Copy link
Owner

Make this lint require explicit closing tags by checking whether parse5 has got an authored location for the endTag. Because void elements do not have an endTag we also must handle them.

Not a change I made, it is taken from this PR:
runem#340

Full details and context can be found in that PR. There are still further improvements that can be made (mentioned in that PR), but this seems like a better approach to build off of than how the rule is currently implemented.

Thank you to the original author!

@changeset-bot
Copy link

changeset-bot bot commented Jan 20, 2025

🦋 Changeset detected

Latest commit: 01a6282

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
lit-analyzer-fork Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@JackRobards JackRobards merged commit 4678e73 into main Jan 20, 2025
6 checks passed
@JackRobards JackRobards deleted the unclosed-tag-rule-improvements branch January 20, 2025 07:47
@github-actions github-actions bot mentioned this pull request Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants