Standardize pyproject.toml (uv support) and improve parsing concurrency #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
project now uv and pip compatible, run uv sync to get started with uv, uv sync --extra dev to install dev dependencies as well
benefits from async http requests, no need to handle requests vulnerability now
made network calls async - httpx, made file operations async - aiofiles, run cpu intensive operations in separate thread, added aiofiles dependency,
next steps - improve perf script, use config files for testing config, improve structure of performance checks, include failure and success rates Signed-off-by: pranshu-raj-211 <pranshuraj65536@gmail.com>
Collaborator
Author
|
Needs automated testing verify outputs same across versions - plan to make a lot more code asynchronous. Suggested pytest approach - unit test for file io and crucial functions (data modifying), integration and e2e tests to ensure pipeline doesn't break. Also need a rework of perf benchmarking, improve it, maybe add multiple trials of parsing the same inputs - take an average. |
Collaborator
Author
|
This PR also fixes the problem with the vulnerability in the requests package version that we're using, and improves existing methods by switching over to async http calls (httpx async client, groq async client). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to improve the repo by:
pyproject.tomlfor uv support.Why was this needed?
requirements.txtand poetry based pyproject (uv is much better than poetry, will see higher adoption).