Merged
Conversation
Contributor
|
is this better than CF maven? |
Contributor
Author
|
Yes, CF maven cannot provide source jars unless you do upload them along with the releases. |
Contributor
|
how does Jitpack solve this? I don't make releases on GitHub |
Contributor
Author
|
Jitpack will run |
Contributor
Author
|
And except the releasing tags (or git tags), you can also use commit id and branch name (the latest commit of that branch) as the artifact version. |
Contributor
|
try it out, I updated the lib repo so you can make a pr |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the jitpack support for your excellent work, so that developers want to integrate with productivemetalworks can use jitpack to include it, which can also provide source jars.
But even with this, there's still something not working, because productivelib is also missing, and your repository seems not updated to the latest version that you released. Can you please update it? And I'll open another PR for jitpack in that repo.
For developers who want to include this project, you need to exclude the productivelib somehow, like: