Skip to content

mandom shader BS. looks fire#36

Open
XircTwerk wants to merge 2 commits intoJCraft-EoE:arch/1.20.1from
XircTwerk:arch/1.20.1-shader
Open

mandom shader BS. looks fire#36
XircTwerk wants to merge 2 commits intoJCraft-EoE:arch/1.20.1from
XircTwerk:arch/1.20.1-shader

Conversation

@XircTwerk
Copy link
Copy Markdown
Contributor

title

@PlanetTeamSpeakk
Copy link
Copy Markdown
Member

Just based off of a quick look, might've missed something, but does this shader simply mix all pixels with pink? Cuz in that case I reckon it might be easier/more maintainable to actually just draw a pink overlay. I.e. a rectangle covering the entire screen with a pink color and an alpha level.

@XircTwerk
Copy link
Copy Markdown
Contributor Author

Just based off of a quick look, might've missed something, but does this shader simply mix all pixels with pink? Cuz in that case I reckon it might be easier/more maintainable to actually just draw a pink overlay. I.e. a rectangle covering the entire screen with a pink color and an alpha level.

yea
so
it does indeed mix every pixel with pink based on the intensity
it does look perfectly fine in-game right now though, so i don't see the issue with adding it as is.

@Ayutac
Copy link
Copy Markdown
Member

Ayutac commented Oct 10, 2025

the issue is that you are manually doing what shaders are for. This decreases maintainability.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants