Change check run "pull_request" trigger to "pull_request_target" #293
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Evidently CI is broken here. I'll do a little digging using this PR. |
Add secret debug. Also I think the answer is that the secret key has to be in the fork repo. So there needs to be a workaround to fix this.
eap
commented
Jan 30, 2026
BenjaminTJohnson
requested changes
Feb 2, 2026
Contributor
BenjaminTJohnson
left a comment
BenjaminTJohnson
left a comment
There was a problem hiding this comment.
just remove the part that tier2 test_check_crtm_random, leaving the CI modification.
eap
changed the title
BenjaminTJohnson
approved these changes
Feb 2, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change check run "pull_request" trigger to "pull_request_target". This will allow pull requests from forks to execute in the correct CI environment with access to the secret keys needed to launch the test on EC2.
I also changed the configuration on this repo to require approval for PR check-runs on pulls from members outside our organization. This will prevent people from issuing "PWN Requests" to harvest our tasty AWS secrets.
One other security note here; the credentials at risk here are very limited in scope (because they were issued with risk management in mind) The AWS credentials only allow for CI launching (and that is rate-limited by budget controls). The git credentials allow read-only access to repos required for the test.