Skip to content

Conversation

@StegmannJCSDA
Copy link
Contributor

@StegmannJCSDA StegmannJCSDA commented Nov 19, 2025

Description

This PR adds the source for a CSV data and I/O utility.

Issue(s) addressed

Resolves #265

Dependencies

N/A

Impact

Expected impact on downstream repositories:
N/A

Checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have run the unit tests before creating the PR

@StegmannJCSDA
Copy link
Contributor Author

This PR is ready for review.

@chengdang chengdang self-requested a review December 9, 2025 04:45
@chengdang
Copy link
Contributor

Hi @StegmannJCSDA, this is cool! Is there any requirement on the CVS file format? Do you think it is a good idea to add an I/O unit test just to demonstrate how to use these modules?

@StegmannJCSDA
Copy link
Contributor Author

Thank you @chengdang!

Is there any requirement on the CVS file format?

-> Right now the code doesn't read the CHAR header. But otherwise it is fairly general. I am still planning to add a header capability though.

Do you think it is a good idea to add an I/O unit test just to demonstrate how to use these modules?

-> Absolutely. I have a test here:
https://github.com/StegmannJCSDA/CSVTOOLS/blob/develop/test/test_readcsv.f90
I'm not sure where to put the test data in CRTMv3 though.

@chengdang
Copy link
Contributor

chengdang commented Dec 9, 2025

I'm not sure where to put the test data in CRTMv3 though.

That's a good point. Almost all I/O unit tests are for coefficient LUTs, so part of fix folder.
@BenjaminTJohnson might have more suggestions

@chengdang
Copy link
Contributor

Thank you @StegmannJCSDA! Sorry about the long pause on this PR.
The CVS data is so small (77 byte), so I'd vote to include them as part of the standard test suite if possible.
What do you think?

@StegmannJCSDA
Copy link
Contributor Author

Hi @chengdang. If you like I can add the tests first and keep them commented out. I could add upload the test data here and you can decide later where to best put it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Basic CSV File Utility

2 participants