TL implementation for aircraft/user-defined level upward/downward#189
Open
TL implementation for aircraft/user-defined level upward/downward#189
Conversation
Contributor
Author
|
@quanhualiu, hello Mark, as we discussed, this is the TL implementation for the updated aircraft level calculation. |
Contributor
StegmannJCSDA
left a comment
There was a problem hiding this comment.
@chengdang Thank you for including me in the review. I just have a few comments so far:
- Are there any test results that highlight the impact of the changes in the Forward module?
- Do the changes for the aircraft mode debugging and the downwelling radiance overlap, or could they have been split up in two PRs?
- Did you use TAPENADE to derive the TL code, or by hand?
- For the regression tests, the
Load_Atm_Data.incfile etc. is repeated in a lot of folders now. Would it make sense to move it down at this point, e.g. tomains/regression?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR contains:
CRTM_ADA_TLCRTM_ADAADA_Module.f90Issue(s) addressed
#182
Dependencies
None
Impact
TL results of aircraft level calculation are updated.
Checklist