refactor(retry): Refactor internals to final and private #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
SmetDenis
commented
Sep 27, 2025
SmetDenis
commented
- Mark strategy classes and internal Exception as final to enforce immutability and clarify API boundary
- Convert many Retry properties and helper methods from protected to private and remove deprecated static defaults to tighten encapsulation
- Add getExceptions() and narrow visibility of buildStrategy/cap/jitter/getDefaultDecider
- Update backoff() return type to mixed and add phan/psalm suppress annotations for analyzers
- Bump PHP requirement to ^8.2 and toolbox-dev to ^7.2; update CI matrix to PHP 8.2-8.4, upgrade upload-artifact to v4, remove schedule cron, and set workflow contents read permission
- Apply minor README formatting fixes
- Mark strategy classes and internal Exception as final to enforce immutability and clarify API boundary - Convert many Retry properties and helper methods from protected to private and remove deprecated static defaults to tighten encapsulation - Add getExceptions() and narrow visibility of buildStrategy/cap/jitter/getDefaultDecider - Update backoff() return type to mixed and add phan/psalm suppress annotations for analyzers - Bump PHP requirement to ^8.2 and toolbox-dev to ^7.2; update CI matrix to PHP 8.2-8.4, upgrade upload-artifact to v4, remove schedule cron, and set workflow contents read permission - Apply minor README formatting fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.