Change of name for the RCR-Fe+Ni benchmark to RCR-Sphere

[mcampos16]

This pull request includes a change of name for the RCR-Fe+Ni benchmark to RCR-Sphere, as well as for its subcases:

• RCR-Fe -> RCR-Sphere_Fe
• RCR-Ni -> RCR-Sphere_Ni

All the affected files (yaml config, raw data and metadata) have been corrected. The test functions associated to this benchmark have also been updated.

This change was applied to attain consistency across all the benchmark and subcases naming in JADE (which is necessary for the Web-App).

Summary by CodeRabbit

• Tests
  • Updated test fixtures and test cases to use the RCR-Sphere benchmark naming convention, replacing previous references to RCR-Fe+Ni across multiple test files.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Walkthrough

This PR systematically renames the RCR-Fe+Ni benchmark to RCR-Sphere across the codebase. Three metadata.json files are updated to change the benchmark_name field, and four test files are updated with corresponding test method renames and YAML path references.

Changes

Cohort / File(s)	Change Summary
Metadata Updates tests/dummy_structure/raw_data/_mcnp_-_FENDL 3.2c_/RCR-Sphere/metadata.json tests/dummy_structure/simulations/_mcnp_-_FENDL 3.2c_/RCR-Sphere/RCR-Sphere_Fe/metadata.json tests/dummy_structure/simulations/_mcnp_-_FENDL 3.2c_/RCR-Sphere/RCR-Sphere_Ni/metadata.json	Updated benchmark_name field from "RCR-Fe+Ni" to "RCR-Sphere" in all three metadata files
Test Method & YAML References tests/post/test_atlas_processor.py tests/post/test_excel_processor.py tests/post/test_raw_processor.py	Renamed test methods from test_RCR_Fe_Ni to test_RCR_Sphere and updated YAML configuration paths from RCR-Fe+Ni.yaml to RCR-Sphere.yaml; updated folder references in path construction from RCR-Fe+Ni to RCR-Sphere

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

• All changes are straightforward metadata updates and test reference changes
• Homogeneous pattern applied consistently across multiple files
• No logic changes, control flow modifications, or algorithmic adjustments
• Updates are purely renaming/configuration-level changes

Possibly related PRs

• Add rcr fe+ss #460: Main PR that renames the RCR-Fe+Ni benchmark to RCR-Sphere, updating metadata and test YAML references accordingly.

Suggested reviewers

• Radiation-Transport
• dodu94

Poem

🐰 A sphere takes shape where iron once lay,
Metadata whispers a name's gentle sway,
Tests renamed with care, paths aligned anew,
RCR-Sphere shines—the old name bids adieu! ✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately and clearly summarizes the main change: renaming the RCR-Fe+Ni benchmark to RCR-Sphere, which is the primary objective of all modifications across metadata files, test cases, and configuration files.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch apply_corrections

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c32ec22 and 5df277a.

⛔ Files ignored due to path filters (39)

• tests/dummy_structure/raw_data/_exp_-_exp_/RCR-Sphere/RCR-Sphere_Fe Coarse neutron flux HPD.csv is excluded by !**/*.csv
• tests/dummy_structure/raw_data/_exp_-_exp_/RCR-Sphere/RCR-Sphere_Fe Coarse neutron flux SSD.csv is excluded by !**/*.csv
• tests/dummy_structure/raw_data/_exp_-_exp_/RCR-Sphere/RCR-Sphere_Fe Neutron flux HPD.csv is excluded by !**/*.csv
• tests/dummy_structure/raw_data/_exp_-_exp_/RCR-Sphere/RCR-Sphere_Fe Neutron flux SSD.csv is excluded by !**/*.csv
• tests/dummy_structure/raw_data/_exp_-_exp_/RCR-Sphere/RCR-Sphere_Fe Total Reaction Rate In.csv is excluded by !**/*.csv
• tests/dummy_structure/raw_data/_exp_-_exp_/RCR-Sphere/RCR-Sphere_Fe Total Reaction Rate Ni.csv is excluded by !**/*.csv
• tests/dummy_structure/raw_data/_exp_-_exp_/RCR-Sphere/RCR-Sphere_Ni Coarse neutron flux HPD.csv is excluded by !**/*.csv
• tests/dummy_structure/raw_data/_exp_-_exp_/RCR-Sphere/RCR-Sphere_Ni Coarse neutron flux SSD.csv is excluded by !**/*.csv
• tests/dummy_structure/raw_data/_exp_-_exp_/RCR-Sphere/RCR-Sphere_Ni Neutron flux HPD.csv is excluded by !**/*.csv
• tests/dummy_structure/raw_data/_exp_-_exp_/RCR-Sphere/RCR-Sphere_Ni Neutron flux SSD.csv is excluded by !**/*.csv
• tests/dummy_structure/raw_data/_exp_-_exp_/RCR-Sphere/RCR-Sphere_Ni Total Reaction Rate In.csv is excluded by !**/*.csv
• tests/dummy_structure/raw_data/_exp_-_exp_/RCR-Sphere/RCR-Sphere_Ni Total Reaction Rate Ni.csv is excluded by !**/*.csv
• tests/dummy_structure/raw_data/_mcnp_-_FENDL 3.2c_/RCR-Fe+Ni/RCR-Fe Neutron flux HPD.csv is excluded by !**/*.csv
• tests/dummy_structure/raw_data/_mcnp_-_FENDL 3.2c_/RCR-Fe+Ni/RCR-Fe Neutron flux SSD.csv is excluded by !**/*.csv
• tests/dummy_structure/raw_data/_mcnp_-_FENDL 3.2c_/RCR-Fe+Ni/RCR-Ni Coarse neutron flux HPD.csv is excluded by !**/*.csv
• tests/dummy_structure/raw_data/_mcnp_-_FENDL 3.2c_/RCR-Fe+Ni/RCR-Ni Coarse neutron flux SSD.csv is excluded by !**/*.csv
• tests/dummy_structure/raw_data/_mcnp_-_FENDL 3.2c_/RCR-Fe+Ni/RCR-Ni Cumulative Reaction Rate In.csv is excluded by !**/*.csv
• tests/dummy_structure/raw_data/_mcnp_-_FENDL 3.2c_/RCR-Fe+Ni/RCR-Ni Neutron flux HPD.csv is excluded by !**/*.csv
• tests/dummy_structure/raw_data/_mcnp_-_FENDL 3.2c_/RCR-Fe+Ni/RCR-Ni Neutron flux SSD.csv is excluded by !**/*.csv
• tests/dummy_structure/raw_data/_mcnp_-_FENDL 3.2c_/RCR-Fe+Ni/RCR-Ni Total Reaction Rate In.csv is excluded by !**/*.csv
• tests/dummy_structure/raw_data/_mcnp_-_FENDL 3.2c_/RCR-Fe+Ni/RCR-Ni Total Reaction Rate Ni.csv is excluded by !**/*.csv
• tests/dummy_structure/raw_data/_mcnp_-_FENDL 3.2c_/RCR-Sphere/RCR-Sphere_Fe Coarse neutron flux HPD.csv is excluded by !**/*.csv
• tests/dummy_structure/raw_data/_mcnp_-_FENDL 3.2c_/RCR-Sphere/RCR-Sphere_Fe Coarse neutron flux SSD.csv is excluded by !**/*.csv
• tests/dummy_structure/raw_data/_mcnp_-_FENDL 3.2c_/RCR-Sphere/RCR-Sphere_Fe Cumulative Reaction Rate In.csv is excluded by !**/*.csv
• tests/dummy_structure/raw_data/_mcnp_-_FENDL 3.2c_/RCR-Sphere/RCR-Sphere_Fe Cumulative Reaction Rate Ni.csv is excluded by !**/*.csv
• tests/dummy_structure/raw_data/_mcnp_-_FENDL 3.2c_/RCR-Sphere/RCR-Sphere_Fe Neutron flux HPD.csv is excluded by !**/*.csv
• tests/dummy_structure/raw_data/_mcnp_-_FENDL 3.2c_/RCR-Sphere/RCR-Sphere_Fe Neutron flux SSD.csv is excluded by !**/*.csv
• tests/dummy_structure/raw_data/_mcnp_-_FENDL 3.2c_/RCR-Sphere/RCR-Sphere_Fe Total Reaction Rate In.csv is excluded by !**/*.csv
• tests/dummy_structure/raw_data/_mcnp_-_FENDL 3.2c_/RCR-Sphere/RCR-Sphere_Fe Total Reaction Rate Ni.csv is excluded by !**/*.csv
• tests/dummy_structure/raw_data/_mcnp_-_FENDL 3.2c_/RCR-Sphere/RCR-Sphere_Ni Coarse neutron flux HPD.csv is excluded by !**/*.csv
• tests/dummy_structure/raw_data/_mcnp_-_FENDL 3.2c_/RCR-Sphere/RCR-Sphere_Ni Coarse neutron flux SSD.csv is excluded by !**/*.csv
• tests/dummy_structure/raw_data/_mcnp_-_FENDL 3.2c_/RCR-Sphere/RCR-Sphere_Ni Cumulative Reaction Rate In.csv is excluded by !**/*.csv
• tests/dummy_structure/raw_data/_mcnp_-_FENDL 3.2c_/RCR-Sphere/RCR-Sphere_Ni Cumulative Reaction Rate Ni.csv is excluded by !**/*.csv
• tests/dummy_structure/raw_data/_mcnp_-_FENDL 3.2c_/RCR-Sphere/RCR-Sphere_Ni Neutron flux HPD.csv is excluded by !**/*.csv
• tests/dummy_structure/raw_data/_mcnp_-_FENDL 3.2c_/RCR-Sphere/RCR-Sphere_Ni Neutron flux SSD.csv is excluded by !**/*.csv
• tests/dummy_structure/raw_data/_mcnp_-_FENDL 3.2c_/RCR-Sphere/RCR-Sphere_Ni Total Reaction Rate In.csv is excluded by !**/*.csv
• tests/dummy_structure/raw_data/_mcnp_-_FENDL 3.2c_/RCR-Sphere/RCR-Sphere_Ni Total Reaction Rate Ni.csv is excluded by !**/*.csv
• tests/dummy_structure/simulations/_mcnp_-_FENDL 3.2c_/RCR-Sphere/RCR-Sphere_Fe/RCR-CF_FE_SR_32c.o is excluded by !**/*.o
• tests/dummy_structure/simulations/_mcnp_-_FENDL 3.2c_/RCR-Sphere/RCR-Sphere_Ni/RCR-CF_Ni_SR_32c.o is excluded by !**/*.o

📒 Files selected for processing (6)

• tests/dummy_structure/raw_data/_mcnp_-_FENDL 3.2c_/RCR-Sphere/metadata.json (1 hunks)
• tests/dummy_structure/simulations/_mcnp_-_FENDL 3.2c_/RCR-Sphere/RCR-Sphere_Fe/metadata.json (1 hunks)
• tests/dummy_structure/simulations/_mcnp_-_FENDL 3.2c_/RCR-Sphere/RCR-Sphere_Ni/metadata.json (1 hunks)
• tests/post/test_atlas_processor.py (1 hunks)
• tests/post/test_excel_processor.py (1 hunks)
• tests/post/test_raw_processor.py (1 hunks)

🧰 Additional context used

🧬 Code graph analysis (3)

tests/post/test_atlas_processor.py (2)

tests/post/test_raw_processor.py (1)

• test_RCR_Sphere (497-510)

tests/post/test_excel_processor.py (1)

• test_RCR_Sphere (315-322)

tests/post/test_raw_processor.py (3)

tests/post/test_atlas_processor.py (1)

• test_RCR_Sphere (305-314)

tests/post/test_excel_processor.py (1)

• test_RCR_Sphere (315-322)

src/jade/config/raw_config.py (2)

• ConfigRawProcessor (11-34)
• from_yaml (23-34)

tests/post/test_excel_processor.py (2)

tests/post/test_raw_processor.py (1)

• test_RCR_Sphere (497-510)

tests/post/test_atlas_processor.py (1)

• test_RCR_Sphere (305-314)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)

• GitHub Check: test (windows-latest, 3.11, false)
• GitHub Check: test (ubuntu-latest, 3.11, false)
• GitHub Check: test (ubuntu-latest, 3.12, false)
• GitHub Check: test (ubuntu-latest, 3.10, false)
• GitHub Check: test (windows-latest, 3.10, false)
• GitHub Check: test (windows-latest, 3.12, false)

🔇 Additional comments (6)

tests/dummy_structure/simulations/_mcnp_-_FENDL 3.2c_/RCR-Sphere/RCR-Sphere_Ni/metadata.json (1)

2-2: Rename in metadata for RCR-Sphere_Ni looks correct

benchmark_name is updated to "RCR-Sphere" while keeping all other metadata intact, which matches the intended pure rename.

tests/dummy_structure/simulations/_mcnp_-_FENDL 3.2c_/RCR-Sphere/RCR-Sphere_Fe/metadata.json (1)

2-2: Rename in metadata for RCR-Sphere_Fe looks correct

benchmark_name is switched to "RCR-Sphere" with all other fields unchanged, which is appropriate for this naming-only update.

tests/dummy_structure/raw_data/_mcnp_-_FENDL 3.2c_/RCR-Sphere/metadata.json (1)

2-2: Raw-data metadata rename to RCR-Sphere is consistent

benchmark_name is now "RCR-Sphere" and all run/library/version fields remain as before, matching the simulations’ metadata and the stated PR goal.

tests/post/test_excel_processor.py (1)

315-322: ExcelProcessor RCR-Sphere test rename and YAML path look correct

The method rename to test_RCR_Sphere and the YAML path update to benchmarks_pp/excel/RCR-Sphere.yaml are consistent with surrounding tests and the new benchmark naming.

tests/post/test_atlas_processor.py (1)

305-314: AtlasProcessor RCR-Sphere test update is consistent

Renaming the test to test_RCR_Sphere and switching to benchmarks_pp/atlas/RCR-Sphere.yaml aligns with the new benchmark naming and with the patterns used by other Atlas tests.

tests/post/test_raw_processor.py (1)

497-510: RawProcessor RCR-Sphere test wiring matches the new naming

The test correctly loads RCR-Sphere.yaml and iterates over the _mcnp_-_FENDL 3.2c_ / RCR-Sphere simulations, mirroring the structure used for RCR-SS and other benchmarks. All associated configuration files and simulation folders exist at their expected paths. No code references to the old RCR-Fe+Ni name remain; the old name persists only in documentation files (docs/source/documentation/benchdesc/rcr/rcr-fe+ni.rst), which is appropriate for historical reference.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[dodu94]

Thanks!