Skip to content

Bugfix: volume.json files should now be copied #467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dodu94 merged 4 commits into from
Dec 9, 2025
Merged

Bugfix: volume.json files should now be copied #467

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4b0aaed
Bugfix: volume.json files should now be copied over to the simulation…
jude-moo Nov 14, 2025
18bef47
Adding more explicit error logging
jude-moo Nov 17, 2025
cf65f9b
Merge branch 'developing' into bugfix/volume_copy
jude-moo Nov 21, 2025
eeac51a
Merged developing branch
jude-moo Dec 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/jade/app/fetch.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,8 +90,9 @@ def fetch_from_gitlab(
gl = gitlab.Gitlab(url=url, private_token=authorization_token, ssl_verify=False)
try:
gl.auth()
except gitlab.exceptions.GitlabAuthenticationError:
except gitlab.exceptions.GitlabAuthenticationError as e:
logging.error("Gitlab authentication failed")
logging.error(e)
return False

# select the correct project
Expand Down
2 changes: 1 addition & 1 deletion src/jade/run/benchmark.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ def write(self, output_folder: PathLike):
path to the output folder.
"""
# write the input to the output folder
self.input._write(output_folder)
self.input.write(output_folder)

def print_metadata(self, outpath: PathLike, metadata_file: PathLike):
"""Print the metadata of the run to the output folder.
Expand Down