Skip to content

Conversation

@anniestaker
Copy link
Collaborator

No description provided.

@coveralls
Copy link

coveralls commented Mar 20, 2025

Coverage Status

coverage: 94.737% (+0.04%) from 94.694%
when pulling 3063356 on annie/retrain-example
into 01f425e on main.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of referring to the jupyter notebook for the training my thought would be to refer them to these functions instead? walandmarks/helpers
/landmark_classification_model_training.py I think you would just run lines 304 to 342?

Copy link
Owner

@Ivaldivi Ivaldivi Mar 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, in theory, if someone wants to retrain the model they would just call create_train_analyze_model from that .py file. I can add a main guard (if name == 'main') that contains the function call so it's ready for the model-maintainer but doesn't get called during unittesting

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay. I added a main guard and did some tweaking of the function. I also updated the doc strings and tests.

Then I updated the instruction file to use this function instead of the notebook.

@Ivaldivi Ivaldivi merged commit 8f42aab into main Mar 20, 2025
5 checks passed
@Ivaldivi Ivaldivi deleted the annie/retrain-example branch March 20, 2025 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants