-
Notifications
You must be signed in to change notification settings - Fork 0
Add Instructions for Model Retraining #77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
instead of referring to the jupyter notebook for the training my thought would be to refer them to these functions instead? walandmarks/helpers
/landmark_classification_model_training.py I think you would just run lines 304 to 342?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, in theory, if someone wants to retrain the model they would just call create_train_analyze_model from that .py file. I can add a main guard (if name == 'main') that contains the function call so it's ready for the model-maintainer but doesn't get called during unittesting
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay. I added a main guard and did some tweaking of the function. I also updated the doc strings and tests.
Then I updated the instruction file to use this function instead of the notebook.
No description provided.