Skip to content

feat: switch to upstream skyra (fixes #196)#198

Open
ItzDerock wants to merge 6 commits intomasterfrom
feat/use-upstream
Open

feat: switch to upstream skyra (fixes #196)#198
ItzDerock wants to merge 6 commits intomasterfrom
feat/use-upstream

Conversation

@ItzDerock
Copy link
Owner

my fork of skyra has fallen way out of date. Moved the custom components over to discord-html-transcripts, and switched to upstream skyra which supports react 19.

As a side effect from skyra's move from stencil to lit for web components, a new issue has emerged: When using the React bindings for lit, none of the props are serialized properly into the rendered result, so this will need to be fixed.

discord-markdown-parser also depends on simple-markdown which currently depends on react 18. I think this can be fixed pretty easily too.

@ItzDerock
Copy link
Owner Author

for those wanting to test this, install discord-html-transcripts@next. Most components should work, but please report any bugs here. Timestamps are currently not formatted correctly--that was something I maintained in my components fork, since upstream skyra doesn't do any timestamp formatting.

I have tried (yet again) to fix the peer react 19 dependency issue, but it also turns out that @khanacademy/simple-markdown is not updated to react 19 and puts a peer requirement of 18. This dependency is introduced from discord-markdown-parser, but in reality, the react version should not matter since discord-markdown-parser doesn't use simple-markdown's react capabilities.

My attempts at fixing this issue have shown me that peer dependency overrides do not propagate down. I will have to fork simple-markdown or simply vendor it into discord-markdown-parser. If someone wants to take a stab at that, just copy contents from https://github.com/Khan/perseus/blob/main/packages/simple-markdown/src/ and move it into /src/simple-markdown and remove all the react-related stuff in the https://github.com/itzderock/discord-markdown-parser repo.

@ItzDerock ItzDerock changed the title feat: switch to upstream skyra feat: switch to upstream skyra (fixes #196) Dec 23, 2025
@Miky88
Copy link

Miky88 commented Jan 21, 2026

Hi! Tried this and got a bunch of

[discord-html-transcripts] Unknown node type: subtext {
  content: [
    { content: 'miky88 ', type: 'text' },
    { content: '(miky88 ', type: 'text' },
    { content: '- 311929179186790400', type: 'text' },
    { content: ')', type: 'text' }
  ],
  type: 'subtext'
}

Using Components V2.
Hope this helps!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants