fix: Fix spelling errors + wrongly formatted json in prompts#1065
Open
northern-64bit wants to merge 7 commits intoItzCrazyKns:masterfrom
Open
fix: Fix spelling errors + wrongly formatted json in prompts#1065northern-64bit wants to merge 7 commits intoItzCrazyKns:masterfrom
northern-64bit wants to merge 7 commits intoItzCrazyKns:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
1 issue found across 2 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="src/lib/prompts/search/classifier.ts">
<violation number="1" location="src/lib/prompts/search/classifier.ts:59">
P2: The prompt claims to provide a JSON output format, but still contains invalid JSON type placeholders (`boolean`/`string`), making the formatting fix incomplete.</violation>
</file>
Since this is your first cubic review, here's how it works:
- cubic automatically reviews your code and comments on bugs and improvements
- Teach cubic by replying to its comments. cubic learns from your replies and gets better over time
- Add one-off context when rerunning by tagging
@cubic-dev-aiwith guidance or docs links (includingllms.txt) - Ask questions if you need clarification on any suggestion
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
Eternalhazed
added a commit
to Eternalhazed/perplexica
that referenced
this pull request
Mar 18, 2026
…CrazyKns#1065) Fixes "independant" -> "independent", "converastion" -> "conversation", and removes trailing comma in JSON example that could cause parse failures. From upstream PR ItzCrazyKns#1065 (northern-64bit) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Fixed spelling errors and an invalid JSON example across search prompts, agents, and the researcher web search action to improve clarity and prevent parsing errors.
src/lib/prompts/search/classifier.ts; “feature”→“features” insrc/lib/prompts/search/researcher.ts; “souce”→“source” and “showed”→“shown” in bothsrc/lib/agents/search/index.tsandsrc/lib/agents/search/api.ts; “this tools”→“this tool” insrc/lib/agents/search/researcher/actions/webSearch.ts.src/lib/prompts/search/classifier.tsby removing a trailing comma.Written for commit 138c56e. Summary will update on new commits.