Skip to content

Add clasp implementation support#4

Merged
ItsMeForLua merged 1 commit intoItsMeForLua:developfrom
sdilts:feat/add-clasp-support
Mar 28, 2026
Merged

Add clasp implementation support#4
ItsMeForLua merged 1 commit intoItsMeForLua:developfrom
sdilts:feat/add-clasp-support

Conversation

@sdilts
Copy link
Copy Markdown

@sdilts sdilts commented Mar 18, 2026

This makes the tests pass, so it's presumably working correctly.

I think (mp:fence :sequentially-consistent) is correct for the memory barrier, but I'm completely new to the concept.

This makes the tests pass, so it's presumably working correctly.:
@ItsMeForLua
Copy link
Copy Markdown
Owner

ItsMeForLua commented Mar 24, 2026

Everything looks good, but give me a couple days to review this PR alongside your other PR so that I can accept both PR's at once. I may instead have you commit the PR to one of the other branches (Ill follow up with another reply in this thread) so we can stage before doing a micro-release in the main branch. But the other branches are a bit messy right now, with some code being updated, and other code being behind the main branch.

And, thank you for your help !

@ItsMeForLua ItsMeForLua added the enhancement New feature or request label Mar 24, 2026
@ItsMeForLua ItsMeForLua changed the base branch from main to develop March 28, 2026 02:14
@ItsMeForLua
Copy link
Copy Markdown
Owner

This PR is being committed to the develop branch for now until everything is set up fully for a release. Thank you for your help!

@ItsMeForLua ItsMeForLua merged commit 73b1b51 into ItsMeForLua:develop Mar 28, 2026
1 check passed
@ItsMeForLua
Copy link
Copy Markdown
Owner

I want to clarify here that right now, cl-freelock's contributor list does not have you listed, but once I push these commits to the main branch, you'll be listed as a contributor. Just wanted to clarify this so that there isn't any confusion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants