feat: created coworker-slug #131
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Denna är ju inte klar än som sagt. Däremot något vi kan lägga till redan nu är stöd för metadata för varje enskild medarbetare. Det finns en |
lundeeell
suggested changes
Nov 26, 2020
Contributor
lundeeell
left a comment
lundeeell
left a comment
There was a problem hiding this comment.
Nice! Missing some styling, but it works!
Would be nice to indicate somehow that coworker is clickable on index (hover effect or something)
| export let coworker | ||
| const [workTitle, phone, email] = coworker.custom_excerpt.split('\n') | ||
| </script> | ||
|
|
Contributor
There was a problem hiding this comment.
Missing meta-tag. For instance <Meta title="Iteam | Om oss - {coworker.title}" />
| @@ -1,59 +0,0 @@ | |||
| <script context="module"> | |||
Contributor
There was a problem hiding this comment.
This file hasn't been removed. Just all content :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created co-workers slug page, not final design.