REPENTOGON Plus Definitions #2

[Syntax-Sculptor]

This is the second PR of three(?), as the amount of API additions, changes and definition fixes are large.

For isaac-typescript-definitions, I had removed Level.GetLastDevilRoomStage as it has been broken since Repentance and only returns an userdata. I plan on moving it over to isaac-typescript-definitions-repentogon as it is fixed there.

[Zamiell]

i reverted the changes to Game.d.ts, since I think it is useful to have the method existing for historical context.
to be clear, the method still does "work" in-game, right? (insofar that it doesn't crash the game and successfully returns metadata.)

[Syntax-Sculptor]

i reverted the changes to Game.d.ts, since I think it is useful to have the method existing for historical context. to be clear, the method still does "work" in-game, right? (insofar that it doesn't crash the game and successfully returns metadata.)

It doesn't cause any crashes, yeah. In that case I'll just add an Ex method that will return a fixed LevelStage while still transpiling to GetLastDevilRoomStage.

[Zamiell]

should I merge this now or are you still working on it?

[Syntax-Sculptor]

yes it can be merged

[Zamiell]

is it not possible for Repentongon function definitions to overwrite vanilla function definitions?
maybe I have asked this before, but it's been a while and I have forgotten.

[Syntax-Sculptor]

is it not possible for Repentongon function definitions to overwrite vanilla function definitions? maybe I have asked this before, but it's been a while and I have forgotten.

Not as far as I know, since it's expected that the overridden interface field should have the same type as the normal one. In the case of GetLastDevilRoomStage, doing it owuld result in the error:

Subsequent property declarations must have the same type. Property 'GetLastDevilRoomStage' must be of type '() => LuaUserdata', but here has type '() => LevelStage'.

[Zamiell]

oh I see, that's very unfortunate

[Zamiell]

should I wait for the next PR until releasing?

[Syntax-Sculptor]

Sure, the last PR should be out sometime today