Codegen Improvements #17
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At first I just wanted to do small cleanup (e.g. utility methods to reduce repeating code etc.), but in the end I'm opting out for a bigger changes. My goal is to split the codegen from 2 logic passes (build + generate) all happening in the
*Instanceclasses, into 3 more separate passes.The result should be a less hacky and less error prone generator. 🤞
High-level overview of the changes, with description of the pass splits:
*Instancemodel classes and will also collect the selector definitionsNaming is not final, I am open to suggestions.
Current state is nearly final, just need to cleanup the changes & finalize naming. Other than that, the changes fixed some wrong selectors and now the output is stable and does not need any manual touch-ups.