my brain is melting#10
Open
edwardrodgermartinez wants to merge 1 commit intoIronhack-data-bcn-oct-2023:mainfrom
Open
my brain is melting#10edwardrodgermartinez wants to merge 1 commit intoIronhack-data-bcn-oct-2023:mainfrom
edwardrodgermartinez wants to merge 1 commit intoIronhack-data-bcn-oct-2023:mainfrom
Conversation
edwardrodgermartinez
commented
Oct 16, 2023

|
Let me tell you: your melting brain did an awesome job on this lab! Some comments: By convention, both pandas are numpy are always imported with aliases, so when you do use them you call them by their alias instead of the whole word: Don’t forget that lists (and list comprehensions) go inside square brackets. When you flattened the list, you used: But you could directly use a list comprehension by using [], no need to cast it as list: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.