Skip to content

my brain is melting#10

Open
edwardrodgermartinez wants to merge 1 commit intoIronhack-data-bcn-oct-2023:mainfrom
edwardrodgermartinez:main
Open

my brain is melting#10
edwardrodgermartinez wants to merge 1 commit intoIronhack-data-bcn-oct-2023:mainfrom
edwardrodgermartinez:main

Conversation

@edwardrodgermartinez
Copy link
Copy Markdown

image

@sh-ih
Copy link
Copy Markdown

sh-ih commented Oct 17, 2023

Let me tell you: your melting brain did an awesome job on this lab!

Some comments:

By convention, both pandas are numpy are always imported with aliases, so when you do use them you call them by their alias instead of the whole word:

import pandas as pd
import numpy as np

Don’t forget that lists (and list comprehensions) go inside square brackets. When you flattened the list, you used:

prophet_flat = list(x for i in prophet_line for x in i)
print(prophet_flat)

But you could directly use a list comprehension by using [], no need to cast it as list:

prophet_flat = [x for i in prophet_line for x in i]
print(prophet_flat)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants