Skip to content

[Uri] lab-functions#6

Open
UriCVV wants to merge 2 commits intoIronhack-data-bcn-oct-2023:mainfrom
UriCVV:main
Open

[Uri] lab-functions#6
UriCVV wants to merge 2 commits intoIronhack-data-bcn-oct-2023:mainfrom
UriCVV:main

Conversation

@UriCVV
Copy link
Copy Markdown

@UriCVV UriCVV commented Oct 12, 2023

No description provided.

@sh-ih
Copy link
Copy Markdown

sh-ih commented Oct 13, 2023

Oriol,
Great job on this lab!

Some comments:
On question 5, you could simplify your code by calling the functions you created on the previous two questions:

def oper_all(arr, oper):
    if oper == "+":
        return sum_all(arr)
    elif oper == "*":
        return mult_all(arr)

And great idea to deal with the case of the oper not being either + or *

Keep using such clear names when naming your variables. It makes easier for someone else (and even future you!) to understand your code👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants