[Clàudia Pintos] lab-functions#12
Open
claudiarelat wants to merge 1 commit intoIronhack-data-bcn-oct-2023:mainfrom
Open
[Clàudia Pintos] lab-functions#12claudiarelat wants to merge 1 commit intoIronhack-data-bcn-oct-2023:mainfrom
claudiarelat wants to merge 1 commit intoIronhack-data-bcn-oct-2023:mainfrom
Conversation
|
Clàudia, Some comments: On question 2, your function passes the test but there is a case where setting largest=0 would create some issues: when your array has only negative numbers. If you run: On question 5, you could simplify your code by calling the functions you created on the previous two questions: I really liked how you named your variables with pretty clear names. That helps a lot when other people (or future you!) uses your code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.