Base Market Deployments

[junkim012]

Overview

• For deploying the weETH/WETH market on base.
• The SpotOracle reads from the Chainlink weETH marker price oracle denominated in ETH.
• The ReserveOracle reads from the Chainlink weETH exchange rate oracle denominated in WETH.
• Tests were added to previous abstract test contracts for SpotOracle and ReserveOracle.

TODOs

• Deployment scripts for weETH/WETH
• WeEthWethSpotOracle and WeEthWethReserveOracle that uses Base feeds and checks for Base sequencer downtime via Chainlink.
• Tests for all new contracts.

Important Changes

• The WeEthWethSpotOracle also checks if the sequencer is down.

• The UniswapFlashloanBalancerSwap contract used to always assume that the base asset of the IonPool it is being used on is mainnet WETH, imported from the Constants.sol file.

  • To make this work for base deployment, the contract was modified to use the BASE variable set from ionPool.underlying() which in the base deployment will be the base WETH.

• Optimizer to 200 to avoid contract size limit violation

• 98e624e

  • New commit that changes the strategy contracts to take in WETH address as a constructor arg instead of a constant.

[openzeppelin-code]

weETH/WETH Base Market Deployment

Generated at commit: d1204b5a83b20db2b366ea894d9b6bee6094a104

🚨 Report Summary

	Severity Level	Results
Contracts	Critical High Medium Low Note Total	2 2 0 12 40 56
Dependencies	Critical High Medium Low Note Total	0 0 0 0 0 0

---

For more details view the full report in OpenZeppelin Code Inspector

[jpick713]

lgtm, just maybe review the sequencer feed checks

[CarsonCase]

Looking good, just a little confusion in the _getUnderlying() function in test/helpers/handlers/IonHandlerForkBase.sol as it uses the mainnet WETH. Overall the differing WETH addresses are quite confusing and it may be worth using an immutable value in the handlers and passing it in as a config value

[CarsonCase]

Do you think it would be worth making weth an immutable value and passing the address in as a constructor arg?

I think it's a bit dangerous leaving this to be hardcoded when deploying on BASE vs other networks

[CarsonCase]

I tried looking into if Uniswap has a WETH() function too, and unfortunately in V3 it does not

[junkim012]

The IonHandlerBase now takes in weth as a constructor arg to set it as an immutable.