Skip to content

Make toBase on Windows behave more like other platforms #482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stevedekorte merged 1 commit into from
Sep 17, 2025
Merged

Make toBase on Windows behave more like other platforms #482

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions libs/iovm/source/IoSeq_immutable.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -854,22 +854,21 @@ IO_METHOD(IoSeq, toBase) {
/*doc Sequence toBase(aNumber)
Returns a Sequence containing the receiver (which is
assumed to be a base 10 number) converted to the specified base.
Only base 8 and 16 are currently supported.
*/

const char *const table = "0123456789abcdefghijklmnopqrstuvwxyz";
int base = IoMessage_locals_intArgAt_(m, locals, 0);
char buf[64], *ptr = buf + 64;
unsigned long n = 0;
uintptr_t n = 0;

if (base < 2 || base > 36) {
IoState_error_(IOSTATE, m, "conversion to base %i not supported", base);
}

#if defined(_MSC_VER) || defined(__MINGW32__)
n = strtoul(IoSeq_asCString(self), NULL, 0);
n = (uintptr_t)strtoull(IoSeq_asCString(self), NULL, 0);
#else
n = (unsigned long)IoSeq_asDouble(self);
n = (uintptr_t)IoSeq_asDouble(self);
#endif

/* Build the converted string backwards. */
Expand Down
Loading