Skip to content

Conversation

@marvinkruse
Copy link
Member

@marvinkruse marvinkruse commented Oct 14, 2025

This pull request refactors how deployment nonces and salts are managed for module proxy creation in the ModuleFactory_v1 contract. The changes are tying the deployment salt to the combination of caller and orchestrator, rather than just the caller. The most important changes are:

Deployment nonce management

  • The _deploymentNonces mapping now uses a bytes32 key (hash of caller and orchestrator addresses) instead of just the caller's address.

Salt generation for proxy deployment

  • The _createSalt function now takes the orchestrator address as a parameter and generates the salt as the hash of the caller and orchestrator hash combined with the nonce, rather than just the caller and nonce. This strengthens and restores the uniqueness and predictability of deployed addresses.

@marvinkruse marvinkruse self-assigned this Oct 14, 2025
@marvinkruse marvinkruse merged commit 8b7bc43 into dev Oct 14, 2025
6 checks passed
@marvinkruse marvinkruse deleted the deterministic-deployment-fix branch October 14, 2025 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants