FIx: Deterministic Deployment Issues #779
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request refactors how deployment nonces and salts are managed for module proxy creation in the
ModuleFactory_v1contract. The changes are tying the deployment salt to the combination of caller and orchestrator, rather than just the caller. The most important changes are:Deployment nonce management
_deploymentNoncesmapping now uses abytes32key (hash of caller and orchestrator addresses) instead of just the caller's address.Salt generation for proxy deployment
_createSaltfunction now takes the orchestrator address as a parameter and generates the salt as the hash of the caller and orchestrator hash combined with the nonce, rather than just the caller and nonce. This strengthens and restores the uniqueness and predictability of deployed addresses.