rework errors #5
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit beee2b3 Author: Phillip Fisher <phillip_fisher@hotmail.com> Date: Mon Jun 30 13:07:44 2025 -0500 fix warnings in protos commit 0b1088e Merge: cd97ffe 0664d5d Author: Phillip Fisher <phillip_fisher@hotmail.com> Date: Mon Jun 30 13:05:27 2025 -0500 Merge branch 'main' of https://github.com/InvertedTech/IT.WebServices commit cd97ffe Author: Phillip Fisher <phillip_fisher@hotmail.com> Date: Mon Jun 30 13:05:23 2025 -0500 Rename PE to Fortis commit 0664d5d Merge: fb711b5 5e6a670 Author: Phillip Fisher <phillip_fisher@hotmail.com> Date: Mon Jun 30 11:36:42 2025 -0500 Merge pull request InvertedTech#3 from amingst/main Events commit fb711b5 Author: Phillip Fisher <phillip_fisher@hotmail.com> Date: Tue Jun 24 17:21:59 2025 -0500 Add in bulk paypal routes
- Simplified logic in `AdminGetEvents` using `if` statements. - Enhanced event retrieval to include both single and template recurring events when `RecurrenceHash` is absent. - Added `GetTemplateRecurringEvents` method to filter and retrieve the earliest recurring events. - Streamlined event addition logic, improving readability and clarity regarding canceled events.
- Introduced `EventVenueHelper` for venue data retrieval. - Updated `AdminEventService` to utilize venue helper. - Added `MaxTickets` property to event-related messages. - Implemented `ReserveTicketForEvent` method in `EventService`. - Commented out unused `Location` property in event records. - Enhanced `EventRecord` and `EventTicketClass` for better ticket management. - Updated settings to support multiple venues for events.
Commented out ticket reservation logic in EventService.cs for future rework. Added TicketClassRecord.proto to enhance ticket class handling. Updated EventTicketClass methods to return TicketClassRecord types, aligning with new data model. Modified EventTicketRecord.proto and EventsSettings.proto to incorporate the new ticket class structure. Ensured consistency across the codebase with these changes.
This commit includes significant refactoring and enhancements across several files, including `AdminEventService.cs`, `EventRecord.proto`, `EventTicketClass.cs`, `EventTicketRecord.cs`, and `SettingsService.cs`. Key changes involve consolidating using directives, improving constructor readability, and updating method signatures for clarity. The handling of event records has been modified to utilize a structured `EventTicketClass` type instead of string-based ticket classes, enhancing type safety. Additionally, new methods have been introduced in `SettingsService.cs` to manage private and owner settings for events, complete with authorization checks. Overall, these changes improve code readability, maintainability, and introduce new functionality for event settings management.
commit beee2b3 Author: Phillip Fisher <phillip_fisher@hotmail.com> Date: Mon Jun 30 13:07:44 2025 -0500 fix warnings in protos commit 0b1088e Merge: cd97ffe 0664d5d Author: Phillip Fisher <phillip_fisher@hotmail.com> Date: Mon Jun 30 13:05:27 2025 -0500 Merge branch 'main' of https://github.com/InvertedTech/IT.WebServices commit cd97ffe Author: Phillip Fisher <phillip_fisher@hotmail.com> Date: Mon Jun 30 13:05:23 2025 -0500 Rename PE to Fortis commit 0664d5d Merge: fb711b5 5e6a670 Author: Phillip Fisher <phillip_fisher@hotmail.com> Date: Mon Jun 30 11:36:42 2025 -0500 Merge pull request InvertedTech#3 from amingst/main Events commit fb711b5 Author: Phillip Fisher <phillip_fisher@hotmail.com> Date: Tue Jun 24 17:21:59 2025 -0500 Add in bulk paypal routes
Introduces scripts and configuration for generating TypeScript from protobuf files, including buf and TypeScript configs, a generation script, and documentation. Updates enum values in AssetInterface.proto and Content.proto to avoid naming conflicts. Adds a README with usage instructions and notes on known issues.
generate ts and zod schemas from protos changesets setup
commit dfec0ff Merge: 39bfc63 9e19211 Author: Andrew Mingst <amingst97@gmail.com> Date: Tue Oct 21 17:10:16 2025 -0400 Merge branch 'protovalidate-net' of https://github.com/amingst/IT.WebServices into protovalidate-net commit 39bfc63 Author: Andrew Mingst <amingst97@gmail.com> Date: Tue Oct 21 16:53:42 2025 -0400 fix protobuf generation commit 9e19211 Author: Andrew Mingst <amingst97@gmail.com> Date: Tue Oct 21 16:53:42 2025 -0400 fix protobuf generation commit 5bae796 Merge: a1e8aa1 c03fd1c Author: amingst <3608359+amingst@users.noreply.github.com> Date: Tue Oct 21 12:13:37 2025 -0400 Merge branch 'Protobuf-Validation-Errors' into protovalidate-net commit a1e8aa1 Author: amingst <3608359+amingst@users.noreply.github.com> Date: Tue Oct 21 10:50:36 2025 -0400 add protovalidate-net add protovalidate-net on CreateUser route commit c03fd1c Author: Andrew Mingst <amingst97@gmail.com> Date: Mon Oct 20 17:20:11 2025 -0400 Change URl validation to be a relative URL instead of absolute commit 06d0eb2 Author: Andrew Mingst <amingst97@gmail.com> Date: Mon Oct 20 16:41:50 2025 -0400 Add Validators for CreateContent ModifyContent commit 52b49e4 Author: amingst <3608359+amingst@users.noreply.github.com> Date: Mon Oct 20 14:25:43 2025 -0400 Validators for CreateContent commit af0a4ff Author: amingst <3608359+amingst@users.noreply.github.com> Date: Mon Oct 20 10:54:47 2025 -0400 Authentication Validation errors on CreateUser AuthenticateUser ModifyOtherUser ModifyOwnUser ChangeOwnPassword ChangeOtherPassword GenerateOwnTOTP GenerateOtherTOTP VerifyOwnTOTP VerifyOtherTOTP commit 781387a Author: Andrew Mingst <amingst97@gmail.com> Date: Fri Oct 17 16:28:29 2025 -0400 flatten generation and remove zod schema generation commit a494384 Author: Phillip Fisher <phillip_fisher@hotmail.com> Date: Wed Aug 20 15:15:36 2025 -0500 Add in old payment id fields commit 3170174 Author: Phillip Fisher <phillip_fisher@hotmail.com> Date: Wed Aug 6 15:06:05 2025 -0500 Fix Fortis reconcile commit d371364 Author: Phillip Fisher <phillip_fisher@hotmail.com> Date: Mon Jul 28 14:32:57 2025 -0500 change payments to use generic objects commit 07579ac Author: Phillip Fisher <phillip_fisher@hotmail.com> Date: Tue Jul 15 17:37:58 2025 -0500 another refinement pass done
commit f0302ea Author: Andrew Mingst <amingst97@gmail.com> Date: Tue Oct 28 21:30:00 2025 -0400 update changelog for npm commit 6d16a6d Author: Andrew Mingst <amingst97@gmail.com> Date: Tue Oct 28 21:26:10 2025 -0400 finsih error migration commit 331e0c0 Author: Andrew Mingst <amingst97@gmail.com> Date: Tue Oct 28 20:02:03 2025 -0400 update services with new error types commit 320f22c Author: Andrew Mingst <amingst97@gmail.com> Date: Tue Oct 28 19:39:23 2025 -0400 error in protos commit b300714 Author: Andrew Mingst <amingst97@gmail.com> Date: Tue Oct 28 16:49:15 2025 -0400 small error debug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.