Remove requirement of "current treasury value" for transactions #1322
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
palas
requested review from
Jimbo4350,
carbolymer and
newhoggy
as code owners
Jimbo4350
requested changes
Jan 16, 2026
palas
force-pushed
the
1149-remove-requirement-of-current-treasury-withdrawal-for-transaction-in-build-raw-command
branch
from
ca753ee to
24d7d28
Compare
carbolymer
reviewed
Jan 20, 2026
carbolymer
reviewed
Jan 20, 2026
cardano-cli/test/cardano-cli-golden/Test/Golden/Conway/Transaction/BuildRaw.hs
Outdated
Show resolved
Hide resolved
palas
force-pushed
the
1149-remove-requirement-of-current-treasury-withdrawal-for-transaction-in-build-raw-command
branch
from
d3f1e86 to
edcde6f
Compare
Jimbo4350
requested changes
Jan 26, 2026
| pCurrentTreasuryValueAndDonation = | ||
| optional ((,) <$> pCurrentTreasuryValue' <*> pTreasuryDonation') | ||
| pCurrentTreasuryValue :: Parser (Maybe TxCurrentTreasuryValue) | ||
| pCurrentTreasuryValue = |
Contributor
There was a problem hiding this comment.
Why not condense pCurrentTreasuryValue and pCurrentTreasuryValue' into one function? pCurrentTreasuryValue' is not used anywhere else.
| asum | ||
| [ Opt.flag' IncludeCurrentTreasuryValue $ | ||
| mconcat | ||
| [ Opt.long "include-current-treasury-value" |
Contributor
There was a problem hiding this comment.
Why deviate from the name that build-raw uses?
| | TxCborNotCanonical | ||
| deriving (Eq, Show) | ||
|
|
||
| -- | Whether to include the current treasury value in the transaction body. |
Contributor
There was a problem hiding this comment.
A better comment would elaborate that this is really aimed at Plutus scripts i.e it is exposed in the plutus script context. This is already implied since it's in the transaction body but being explicit about it lets us know what specifically it's related to.
|
|
||
| -- | Whether to include the current treasury value in the transaction body. | ||
| -- If included, the current treasury value will be obtained from the node. | ||
| data IncludeCurrentTreasuryValue = IncludeCurrentTreasuryValue | ExcludeCurrentTreasuryValue |
Contributor
There was a problem hiding this comment.
Why are you introducing this sum type? It's not necessary. What is wrong with (Maybe TxCurrentTreasuryValue)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Context
See #1149
How to trust this PR
Ensure that only the specified restriction was lifted and in the appropriate places. Ensure this is the right thing to do. Confirm I interpreted this message correctly: https://discord.com/channels/1136727663583698984/1239888777015590913/1364244737602879498
Checklist