Replace implicit fromIntegral explicit usage
#609
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
perturbing
force-pushed
the
perturbing/fix-fromIntegral
branch
from
52bfe4f to
8f2f69d
Compare
f-f
approved these changes
Jan 19, 2026
Contributor
f-f
left a comment
f-f
left a comment
There was a problem hiding this comment.
fromIntegral type applications, lovely 🙂
neilmayhew
requested changes
Jan 19, 2026
Contributor
neilmayhew
left a comment
neilmayhew
left a comment
There was a problem hiding this comment.
Good improvement!
Some minor suggestions. Although there's a lot, all but one of them are referring to the same issue repeated throughout the code.
Member
Author
|
@neilmayhew, thanks for the sharp eye and the review! |
lehins
approved these changes
Jan 20, 2026
Collaborator
lehins
left a comment
lehins
left a comment
There was a problem hiding this comment.
Thank you for going through the repo and annotating all of those conversions!
neilmayhew
approved these changes
Jan 21, 2026
…ource/target types using `TypeApplications`.
Co-authored-by: Neil Mayhew <neil@mayhew.name>
Co-authored-by: Alexey Kuleshevich <alexey.kuleshevich@iohk.io>
perturbing
force-pushed
the
perturbing/fix-fromIntegral
branch
from
54c292c to
85a993f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #603