Support ghc-9.14

[erikd]

Description

Ghc-9.14 support. Currently using ghc-9.14.0.1.

Checklist

• Commit sequence broadly makes sense and commits have useful messages
• New tests are added if needed and existing tests are updated
• All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages.
  New section is never added with the code changes. (See RELEASING.md)
• When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
  versioning process.
• The version bounds in .cabal files for all affected packages are updated.
  If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
• Self-reviewed the diff

[erikd]

Have no idea what the fourmolu check is complaining about. Maybe it does not like CPP. When I run it locally it does not make any changes but exits with error code 102 like it does in CI.

[lehins]

Same comment about CPP as in IntersectMBO/cardano-ledger#5292

[erikd]

Same comment about CPP as in IntersectMBO/cardano-ledger#5292

Good suggestion. Looking into it now.

[erikd]

The cabal-format test is failing due to having added comments to the allow-newer statements.

I added:

if impl(ghc >=9.14)
  allow-newer:
    -- https://github.com/haskell/aeson/issues/1155
    , aeson:base
    , aeson:bytestring
    , aeson:deepseq
    , aeson:ghc-prim
    , aeson:template-haskell
    , aeson:time

    -- https://github.com/haskellari/binary-orphans/issues/67
    , binary-orphans:base

    -- https://github.com/phadej/boring/issues/48
    , boring:base

and cabal-format reformats it as:

if impl(ghc >=9.14)
  allow-newer:
    -- https://github.com/haskell/aeson/issues/1155
    -- https://github.com/haskellari/binary-orphans/issues/67
    -- https://github.com/phadej/boring/issues/48
    , aeson:base
    , aeson:bytestring
    , aeson:deepseq
    , aeson:ghc-prim
    , aeson:template-haskell
    , aeson:time
    , binary-orphans:base
    , boring:base

which is just dumb.

[lehins]

which is just dumb.

Unfortunately cabal formatting tool isn't capable of handling comments very well, limitation of the tool itself that we can't really do anything about.

Before merging the PR if some of those allow-newers are still needed, instead of bunch of links to other repos as comments it is better to create an actual ticket on this reposiory and that issue would link to all of those other issues on other repos.

Until it is ready to be merged cabal formatting CI check isn't that important anyways

[erikd]

Created issue #613 to track alllow-newer issue.

Have removed the commits from the cabal.project file.