MMScan devkit#88
Merged
Tai-Wang merged 18 commits intoInternRobotics:mmscanfrom Dec 26, 2024
rbler1234:mmscan-devkit
Merged
Conversation
mxh1999
requested changes
Nov 21, 2024
Collaborator
mxh1999
left a comment
mxh1999
left a comment
There was a problem hiding this comment.
I think the structure is a little strange.
Maybe it would be better not to be a branch of embodiedscan
mxh1999
requested changes
Nov 25, 2024
mxh1999
reviewed
Nov 27, 2024
Collaborator
mxh1999
left a comment
mxh1999
left a comment
There was a problem hiding this comment.
I think the code (excluding the third-party model) is ok
mxh1999
approved these changes
Nov 29, 2024
Collaborator
|
@rbler1234 Don't modify this branch until it has been merged, you can create another branch for develop. |
Tai-Wang
reviewed
Dec 13, 2024
Tai-Wang
reviewed
Dec 13, 2024
data_preparation/README.md
Outdated
| 4. Organize the file structure. You are recommanded to create a soft link to the raw data folder under `mmsan_data/embodiedscan-split/data`. | ||
|
|
||
| ``` | ||
| mmsan_data/embodiedscan-split/data/ |
Contributor
There was a problem hiding this comment.
typo, mmscan, please also fix other places
Contributor
There was a problem hiding this comment.
Why do we need the embodiedscan-split folder
Tai-Wang
reviewed
Dec 13, 2024
Tai-Wang
reviewed
Dec 13, 2024
Tai-Wang
reviewed
Dec 13, 2024
Tai-Wang
reviewed
Dec 13, 2024
Tai-Wang
reviewed
Dec 13, 2024
Tai-Wang
reviewed
Dec 13, 2024
Tai-Wang
reviewed
Dec 13, 2024
Tai-Wang
reviewed
Dec 17, 2024
| es_anno = {} | ||
|
|
||
|
|
||
| def mmengine_track_func(func): |
Contributor
There was a problem hiding this comment.
Is this function necessary?
Collaborator
Author
There was a problem hiding this comment.
It is necessary if using the 'mmengine' to run multi-process multi-parameter functions.
Tai-Wang
reviewed
Dec 17, 2024
Tai-Wang
reviewed
Dec 17, 2024
Tai-Wang
reviewed
Dec 17, 2024
Tai-Wang
reviewed
Dec 17, 2024
Tai-Wang
reviewed
Dec 17, 2024
Tai-Wang
reviewed
Dec 17, 2024
Tai-Wang
reviewed
Dec 17, 2024
Tai-Wang
reviewed
Dec 17, 2024
Tai-Wang
reviewed
Dec 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Modification
Update the branch regarding MMScan.
Modification
(The model-related code will be uploaded subsequently.）
BC-breaking (Optional)
Does the modification introduce changes that break the back-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.
Checklist