Moving towards 1.21 update #677
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
December 27, 2024 13:03
Collaborator
Closed
Contributor
Author
Okay, I'll close #676 and commit all changes here |
SirEndii
requested changes
Jan 2, 2025
|
|
||
| public void initiate() { | ||
| api.getNetworkNodeRegistry().add(new ResourceLocation(AdvancedPeripherals.MOD_ID, "rs_bridge"), (tag, world, pos) -> read(tag, new RefinedStorageNode(world, pos))); | ||
| api.getNetworkNodeRegistry().add(ResourceLocation.fromNamespaceAndPath(AdvancedPeripherals.MOD_ID, "rs_bridge"), (tag, world, pos) -> read(tag, new RefinedStorageNode(world, pos))); |
Member
There was a problem hiding this comment.
Moving to AdvancedPeripherals.getRL would be neat
| @Override | ||
| public ResourceLocation getId() { | ||
| return new ResourceLocation(AdvancedPeripherals.MOD_ID, "rs_bridge"); | ||
| return ResourceLocation.fromNamespaceAndPath(AdvancedPeripherals.MOD_ID, "rs_bridge"); |
Member
There was a problem hiding this comment.
Moving to AdvancedPeripherals.getRL would be neat
| @Override | ||
| public ResourceLocation getTexture() { | ||
| return new ResourceLocation(AdvancedPeripherals.MOD_ID, "textures/gui/inventory_manager_gui.png"); | ||
| return ResourceLocation.fromNamespaceAndPath(AdvancedPeripherals.MOD_ID, "textures/gui/inventory_manager_gui.png"); |
Member
There was a problem hiding this comment.
Moving to AdvancedPeripherals.getRL would be neat
| public static void registerModels(ModelEvent.RegisterAdditional event) { | ||
| for (String model : TURTLE_MODELS) { | ||
| event.register(new ModelResourceLocation(new ResourceLocation(AdvancedPeripherals.MOD_ID, model), "inventory")); | ||
| event.register(new ModelResourceLocation(ResourceLocation.fromNamespaceAndPath(AdvancedPeripherals.MOD_ID, model), "inventory")); |
Member
There was a problem hiding this comment.
Moving to AdvancedPeripherals.getRL would be neat
Member
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some EventBusSubscriber, ResourceLocation and ServerTickEvent related code has been updated to 1.21, but the network and the new Data Component still need to be changed