Draft
Conversation
meghanmae
reviewed
Aug 29, 2024
| [Edit(Roles.Admin)] | ||
| [Create(SecurityPermissionLevels.DenyAll)] | ||
| [Delete(SecurityPermissionLevels.DenyAll)] | ||
| public class AppUser: IdentityUser |
Collaborator
There was a problem hiding this comment.
Question for Andrew: Does the information on Identity User get exposed to the client via coalesce? (e.g. the password hash?)
Is this the best way to hide it?
[InternalUse]
public override string? PasswordHash { get; set; }There was a problem hiding this comment.
The answer lies in the generated DTOs, and it is "yes".
And yes.
|
Is the exact goal here to add JWT bearer tokens as the authentication scheme? This could be substantially simpler if opaque bearer tokens or cookies are suitable. https://learn.microsoft.com/en-us/aspnet/core/security/authentication/identity-api-authorization. You could delete the controller, and most of the configuration in Program.cs In terms of presenting this in the format of the show, I think this is 3 episodes?
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't merge this, just for diffs and comments