Skip to content

Conversation

@mzweilin
Copy link
Contributor

@mzweilin mzweilin commented May 6, 2025

What does this PR do?

This PR adds two callbacks that can be configured to log scalars, compute and log metrics for models that return a dictionary.

The features were implemented in LitModular, but we would like to get access to the features in callbacks when we don't use LitModular.

Type of change

Please check all relevant options.

  • Improvement (non-breaking)
  • Bug fix (non-breaking)
  • New feature (non-breaking)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Testing

Please describe the tests that you ran to verify your changes. Consider listing any relevant details of your test configuration.

  • pytest
  • CUDA_VISIBLE_DEVICES=0 python -m mart experiment=CIFAR10_CNN_Adv trainer=gpu trainer.precision=16 reports 70% (21 sec/epoch).
  • CUDA_VISIBLE_DEVICES=0,1 python -m mart experiment=CIFAR10_CNN_Adv trainer=ddp trainer.precision=16 trainer.devices=2 model.optimizer.lr=0.2 trainer.max_steps=2925 datamodule.ims_per_batch=256 datamodule.world_size=2 reports 70% (14 sec/epoch).

Before submitting

  • The title is self-explanatory and the description concisely explains the PR
  • My PR does only one thing, instead of bundling different changes together
  • I list all the breaking changes introduced by this pull request
  • I have commented my code
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have run pre-commit hooks with pre-commit run -a command without errors

Did you have fun?

Make sure you had fun coding 🙃

@mzweilin mzweilin changed the title Strip away the metrics logging feature in LitModular as the LogMetrics callback Strip away the metrics logging in LitModular as the LogMetrics callback May 6, 2025
@mzweilin mzweilin requested a review from dxoigmn May 6, 2025 23:27
@mzweilin mzweilin changed the title Strip away the metrics logging in LitModular as the LogMetrics callback Strip away the metrics and logging in LitModular as callbacks May 7, 2025
dxoigmn
dxoigmn previously approved these changes May 7, 2025
@mzweilin mzweilin merged commit aa8ade1 into main May 7, 2025
6 checks passed
@mzweilin mzweilin deleted the mzweilin/callback_log_metrics branch May 7, 2025 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants