Create CodemodCommand Remove/Add Import helper functions #1432
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
One of the key features of the
CodemodCommandclass is that it abstracts away the final run ofAddImportsVisitorandRemoveImportsVisitorintransform_module(Code Source). However, currently developers still need to utilize the static functions:RemoveImportsVisitor.remove_unused_importRemoveImportsVisitor.remove_unused_import_by_nodeAddImportsVisitor.add_needed_importTo actually manage the import states in the
self.context: CodemodContext. I propose defining these three new instance functions on CodemodCommand:remove_unused_importremove_unused_import_by_nodeadd_needed_importThese new lightweight helper wrapper functions defined on
CodemodCommandwill help to hopefully completely abstract awayRemoveImportsVisitorandAddImportsVisitor.[Example] Remove + Add Imports
Before:
After:
Test Plan
Specific Unit Tests found in:
and can be run using
[IG][Meta] Would be nice to have this to lower barrier of entry for using
CodemodCommand.