Skip to content

Use ThreadPool if GIL is disabled#1335

Merged
zsol merged 1 commit intomainfrom
fix-threadpool-condition
May 25, 2025
Merged

Use ThreadPool if GIL is disabled#1335
zsol merged 1 commit intomainfrom
fix-threadpool-condition

Conversation

@zsol
Copy link
Contributor

@zsol zsol commented May 25, 2025

#1295 introduced a bug where libcst would use a ThreadPool if the GIL was enabled. That's clearly the wrong thing to do :)

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 25, 2025
@zsol zsol merged commit b560ae8 into main May 25, 2025
32 checks passed
@zsol zsol deleted the fix-threadpool-condition branch May 25, 2025 19:13
jorenham pushed a commit to jorenham/LibCST that referenced this pull request Feb 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants